Add option to load app props from AWS Parameter Store #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be reusable by other PASS services
To load app props
|
The acceptance tests are failing because pass-docker needs to be updated to use the new pass core user env names. I think this is a case where we will have to merged one of the PRs first to get the other to pass. I'd say to merge this one first, then we can re-run the pass-docker PR to ensure it works. |
This was referenced Oct 7, 2024
markpatton
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to load application properties defined in application.yaml from and AWS Parameter Store.
The PR contains the following changes:
PASS_CORE_BACKEND_USERandPASS_CORE_BACKEND_PASSWORDtoPASS_CORE_USERandPASS_CORE_PASSWORDrespectively. This will set up usage of these by other services/data loaders in PASS.The way it works is by using the
spring.config.importto specify to load app props from the AWS parameter store. See the AwsParamStoreConfigTest.properties method for an example.https://docs.awspring.io/spring-cloud-aws/docs/3.0.0/reference/html/index.html#spring-cloud-aws-parameter-store
Note that this PR needs to be approved and merged before the other PR in pass-support. This is because of the pass core user/password env var name change.